SERVER-123310 Remove nsToDatabase() in favor of nsToDatabaseSubstring()#1817
Open
EdanStasiuk wants to merge 1 commit into
Conversation
EdanStasiuk
force-pushed
the
SERVER-123310-make-nsToDatabase-return-StringData-instead-of-std-string
branch
from
5aa0040 to
2bfc1c2
Compare
Author
|
Happy to revert to just changing the return type to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SERVER-123310
nsToDatabase()was a thin wrapper aroundnsToDatabaseSubstring()that returnedstd::string, causing an unnecessary string copy. Rather than changing the return type toStringData(as the TODO requested), the function was removed entirely since it was identical in behavior tonsToDatabaseSubstring(). All callers already usednsToDatabaseSubstring()directly, so no call sites needed updating.